Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added MSI dialogs are not included in MSP #2430

Closed
wixbot opened this issue Jan 7, 2010 · 9 comments
Closed

Newly added MSI dialogs are not included in MSP #2430

wixbot opened this issue Jan 7, 2010 · 9 comments
Labels

Comments

@wixbot
Copy link

wixbot commented Jan 7, 2010

New MSI UI dialogs are not included in MSP even though new properties in the same fragment added to the updated MSI are patched successfully. Note that all the newly added properties and dialogs are directly under Product element (of MSI WXS file). I talked to Heath offline about this and according to him - "Patches contain any changes to (almost) any elements in a fragment as long as you reference at least 1 element from that fragment." which does not seem to hold true in my patching scenario.

With reference to the WXS files in the attached ZIP file, the new properties I mentioned above are ProgressType0 thru ProgressType3 and are located in the Server.wxs. I am able to patch these successfully after I added them to Patch.wxs. And the new MSI dialogs that were added in the updated MSI are FilesInUse and ProgressDlg which are being included in the patch.

Originally opened by sharatja from http://sourceforge.net/p/wix/bugs/1894/

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

The source files had a number of errors so that they wouldn't build. This is beyond missing files, which I changed to just use the $(sys.SOURCEFILEPATH) (the source file itself, which is always present). The namespace was for WiX 2.0, which pyro can support. But there were a number of syntax errors like a stray #text element under InstallUISequence. I fixed these errors, along with a few other minor changes noted below.

With WiX v3.0 RTM (3.0.5419) this works as described. The dialogs are added, along with all controls and events. I have ZIP'd up my results for you to take a look at.

Something to note is that this patch is not recommend as authored. You're auto-generating the ProductCode, and since you only have one fragment (the entry section) selecting anything from there also selects every other change including the ProductCode. Patches that change the ProductCode are not recommended by the Windows Installer team, so WiX does not recommend these patches either because of the issues they cause.

I suggest you fix your ProductCode. You should also not change your UpgradeCode. This is a code that identifies a family of products, whether different products with the same version (a SKU of packages), or across multiple ProductVersion changes. This also won't work with the Upgrade element (Upgrade table) authoring, since the same ID won't be generated. Thus, the Upgrade table is ineffective as authored.

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

The original WXS file is attached. The updated file is already a part of the pervious attachment "WIX_Patching.zip".

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

In order to diagnose any potential issue, I need to have a working sample that uses the same fragmentation. For example, if you added the FilesInUse dialog to a different fragment you need to replicate that - not to mention reference that fragment in a PatchFamily (though DialogRef is not supported).

Note that WixUI is authored into many different fragments and patching those dialogs in is currently not supported.

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

Heath, the source files I shared with you are not the original installer files. I removed the actual product codes and put the "?'" characters in it as this is a public facing discussion list.

Regarding the dialogs that were not being patched, one of them is the FilesInUse dialog. I can share the original files with you, if you would like to take a look.

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

Original Server WXS file

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

WXS files for both Server MSI and Patch

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

Can you attach the before and after server.wxs files so I can see the actual difference? Which UI dialogs are you trying to add and which were already there?

@wixbot
Copy link
Author

wixbot commented Sep 21, 2012

Working example

@wixbot
Copy link
Author

wixbot commented Dec 10, 2013

Originally changed by barnson
Area changed from pyro to
Releasechanged fromfutureto
Resolutionset tofixed
Statuschanged fromUntriagedtoResolved

@wixbot wixbot added the bug label Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant