Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect operation for detect-only package #3643

Closed
wixbot opened this issue Jun 4, 2012 · 6 comments
Closed

Incorrect operation for detect-only package #3643

wixbot opened this issue Jun 4, 2012 · 6 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Jun 4, 2012

Version: 3.6.2928.0

In my MSI I have authored a detect-only package in the upgrade table (to detect the VSTO runtime for use in a launch condition). When burn detects this package (with a product code of "{11538652-E5E4-37F1-86D7-418871E45292}") it calculates the operation as a "MajorUpgrade" instead of "none".

I have attached my exported upgrade table and burn log as requested. I also attached my burn manifest because I noticed the RelatedPackage/@OnlyDetect attribute is set to no instead of "yes" (so at least part of the issue is at compile time).

Originally opened by henny5225 from http://sourceforge.net/p/wix/bugs/2970/

@wixbot
Copy link
Author

wixbot commented May 11, 2013

I'm experiencing this issue with one of my installers that also had a DetectOnly line in the Upgrade Table. Removing the additional Upgrade Table entry has fixed the problem, but there might be a need for such a table entry in the future. The Upgrade Table entry in question was obsolete and easily removed.

@wixbot
Copy link
Author

wixbot commented May 11, 2013

This is actually by design: A typical use case for a detect-only Upgrade row is to block a user attempt to downgrade (i.e., detect a later version of the app already installed). Burn uses that to signal that the package being installed is obsolete. So we prevent that for detect-only rows that have an upgrade code different than the package's own upgrade code. There are two cosmetic side-effects: OnlyDetect="no" shows up in the manifest and MajorUpgrade appears in the Burn log. Otherwise, Burn does nothing about the MajorUpgrade operation in the actual plan. (Burn lets MSI deal with the actual work for related packages.) I'll leave this bug open for v3.7 to see if we want to clean up the cosmetics (e.g., by adding 'Unrelated="yes"' or something to the manifest, or dropping the Upgrade row entirely).

@wixbot
Copy link
Author

wixbot commented May 11, 2013

Files

@wixbot
Copy link
Author

wixbot commented Oct 29, 2013

Originally changed by barnson
Release changed from v3.8 to v3.x

@wixbot
Copy link
Author

wixbot commented Jan 26, 2014

Originally changed by rseanhall
AssignedTo set to shall

@wixbot
Copy link
Author

wixbot commented Mar 24, 2014

The pull request at https://wix.codeplex.com/SourceControl/network/forks/seanhall/working/contribution/6146 was accepted in v4.0.
(wixtoolset/codeplex@0ccd3d5)

Originally posted by rseanhall
Release changed from v3.x to v4.0
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
@rseanhall rseanhall added this to Done in wix.4.0-preview.0 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants