Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegAddValue and ExecXmlFile custom actions write security information into the log file #3859

Closed
wixbot opened this issue Dec 10, 2012 · 2 comments

Comments

@wixbot
Copy link

wixbot commented Dec 10, 2012

If you try to change sml file by Util:XmlFile tag or to write registry keys by RegistryValue tag, you will see infromation in log like the following:
MSI (s) (FC:1C) [12:41:48:619]: Executing op: RegAddValue(Name=DB Connection String,Value=Data Source=SQLServerName;Initial Catalog=DatabaseName;User ID=login;Password=pass;Connect Timeout=120,)
or
MSI (s) (0C:80) [15:27:09:048]: Executing op:
CustomActionSchedule(Action=ExecXmlFile,ActionType=3073,Source=BinaryData,Tar
get=ExecXmlFile,CustomActionData=
2 0 C:\Program
Files\ProgramName\Web.config€3€0€/configuration/system.web/sessionState/@sqlc
onnectionString€€Data Source=SQL_SERVER;User ID=Login;Password=Pass) . . .
Executing op: RegAddValue(Name=DB Connection String,Value=Data Source=
SQL_SERVER;Initial Catalog=DBName;User ID=Login;Password=Pass;Connect
Timeout=120,)
WriteRegistryValues: Key: \SOFTWARE\ProgramNameKey, Name: DB Connection
String, Value: Data Source= SQL_SERVER;Initial Catalog=DBName;User
ID=Login;Password=Pass;Connect Timeout=120

To fix this situation ou should add HideTarget parameter to CustomAction element for RegAddValue and ExecXmlFile custom actions.

See
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Prevent-logging-td7582177.html
for details.

Originally opened by kong83 from http://sourceforge.net/p/wix/bugs/3163/

@wixbot
Copy link
Author

wixbot commented Oct 17, 2013

We don't hide these strings by default because they contain useful debugging info. RegAddValue is an MSI operation so you can't hide them via properties.

Originally posted by barnson
Area set to extensions

@wixbot
Copy link
Author

wixbot commented Oct 17, 2013

Originally changed by barnson
Resolution set to notabug
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant