Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch bundle uninstall doesn't remove superseded msp patches #4033

Closed
wixbot opened this issue Jun 17, 2013 · 12 comments
Closed

patch bundle uninstall doesn't remove superseded msp patches #4033

wixbot opened this issue Jun 17, 2013 · 12 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Jun 17, 2013

When using patch bundles with superseding patches, overwriting a previous bundle (same bundle upgradecode) or removing a previously installed bundle from ARP (different bundle upgrade codes so that bundle patch v1.1 is installed alongside v1.2), superseded msp patches of the uninstalling bundle are not removed.
During detection and planning, their state "superseded" is correctly recognized, but the planned action is not to do anything. That leaves the superseded patch on the system, while the bundle which deployed it on the system is removed. Especially when having the msi packages of the bundle being "not visible", the patch v1.1 is difficult to uninstall since it doesn't show in ARPs updates; also, the user won't know nor guess that patch v1.1 will be still on the system.

Log of the bundle showing detection and planning: bundle is detected and uninstalled, superseded patch SamplePackPatch is detected but left on the system.

[08F0:0730][2013-06-13T23:20:27]i100: Detect begin, 1 packages
[08F0:0730][2013-06-13T23:20:27]i102: Detected related bundle:
{1ad24786-fd8b-4229-840a-725f80e6baa9}, type: Dependent, scope: PerMachine,
version: 1.0.0.0, operation: None
[08F0:0730][2013-06-13T23:20:27]i106: Calculating patch applicability for
target product code: {48C49ACE-90CF-4161-9C6E-9162115A54DD}, context:
Machine
[08F0:0730][2013-06-13T23:20:27]i101: Detected package: SamplePackPatch,
state: Superseded, cached: Complete
[08F0:0730][2013-06-13T23:20:27]i105: Detected package: SamplePackPatch
target: {48C49ACE-90CF-4161-9C6E-9162115A54DD}, state: Superseded
[08F0:0730][2013-06-13T23:20:27]i199: Detect complete, result: 0x0
[08F0:0730][2013-06-13T23:20:30]i200: Plan begin, 1 packages, action:
Uninstall
[08F0:0730][2013-06-13T23:20:30]i207: Planned related bundle:
{1ad24786-fd8b-4229-840a-725f80e6baa9}, type: Dependent, default requested:
None, ba requested: None, execute: None, rollback: None, dependency: None
[08F0:0730][2013-06-13T23:20:30]i201: Planned package: SamplePackPatch,
state: Superseded, default requested: Absent, ba requested: Absent,
execute: None, rollback: None, cache: No, uncache: No, dependency:
Unregister
[08F0:0730][2013-06-13T23:20:30]i299: Plan complete, result: 0x0

Originally opened by jakobzzz from http://sourceforge.net/p/wix/bugs/3321/

@wixbot
Copy link
Author

wixbot commented Sep 26, 2013

Originally changed by barnson
Area set to burn
AssignedTo set to robmen

@wixbot
Copy link
Author

wixbot commented Nov 14, 2013

Suggest taking to v3.9 since I won't have time to verify.

Originally posted by robmen
Status changed from Open to Untriaged

@wixbot
Copy link
Author

wixbot commented Nov 14, 2013

Originally changed by barnson
Release changed from v3.8 to v3.9

@wixbot
Copy link
Author

wixbot commented Oct 17, 2014

Originally changed by robmen
Release changed from v3.9 to v3.10

@wixbot
Copy link
Author

wixbot commented Apr 28, 2015

This appears to be fixed in WiX v3.9 by a different commit.

Originally posted by robmen
Resolution set to fixed
Status changed from Open to Resolved

@wixbot
Copy link
Author

wixbot commented May 26, 2015

using Burn v3.9.1208.0 - issue still present

Originally posted by flury

@wixbot
Copy link
Author

wixbot commented May 26, 2015

Hi there
I am using burn v3.9.1208.0, and there is still the issue of patch1 is still applied after removing patch2, but patch1 no longer in visible in 'Uninstall an update' window.
Thanks

Originally posted by flury
Status changed from Resolved to Untriaged

@wixbot
Copy link
Author

wixbot commented May 31, 2015

Please upload logs from uninstalling patch 2 and post the link here.

Originally posted by barnson

@wixbot
Copy link
Author

wixbot commented Jun 2, 2015

It looks like issue 4779: #4779. Can you post logs to verify?

@wixbot
Copy link
Author

wixbot commented Jun 2, 2015

Yes, I submitted this as issue 4779, sorry for the confusion.

Also I submitted issue 4779 under a different account as with my fist account, I did not supply a username, and the system ended up showing my email as username.

I added logs to issue 4779, but I would like to supply more info. Is there a way to upload a zip package?

Originally posted by melmelrob

@wixbot
Copy link
Author

wixbot commented Jun 3, 2015

You can't directly attach files here but if you upload them to SkyDrive, Google Drive, DropBox, etc., you can paste a public link here. I'm going to mark this triaged so if you can, post the .zip link to http://wixtoolset.org/issues/4779/.

Status changed from Untriaged to Resolved

@wixbot
Copy link
Author

wixbot commented Jun 3, 2015

posted to http://wixtoolset.org/issues/4779 ... thanks

Originally posted by melmelrob

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants