Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Migrate various patch build and install issues #4241

Closed
wixbot opened this issue Dec 18, 2013 · 3 comments
Closed

[MS] Migrate various patch build and install issues #4241

wixbot opened this issue Dec 18, 2013 · 3 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Dec 18, 2013

We have resolved a number of bugs we would like to contribute back to open source in batches.

  1. Always store the unresolved path even during double bind (20661). This can happen when building unresolved outputs then later binding them completely.
  2. Make sure all patches are cached even if they apply to earlier packages (20682). If patches are authored later in the sequence, they may not be cached in time to be installed with an MSI already planned.
  3. BA need the ProductCode in the BA.xml to determine which MSPs get installed separately and which get slipstreamed with MSIs in the package. (20864)
  4. Correct logging that made diagnostics difficult along with a patch issue it covered up. (20815)
  5. Support MSI 3.0-style patching while grabbing all changes (20661). There was a bug in our previous assumption when we created the patch build feature. This is necessary to still build an MsiPatchSequence table but still pull all changes into a patch. That table is necessary to trigger some MSI 3.0-style patching behavior.

Originally opened by heaths

@wixbot
Copy link
Author

wixbot commented Dec 18, 2013

Also,

  1. BA need the ProductCode in the BA.xml to determine which MSPs get installed separately and which get slipstreamed with MSIs in the package. (20864)

I see there is an open bug for part of this already, but could fix it as part of this issue.

Originally posted by heaths

@wixbot
Copy link
Author

wixbot commented Dec 18, 2013

Also,

  1. Correct logging that made diagnostics difficult along with a patch issue it covered up. (20815)

Originally posted by heaths

@wixbot
Copy link
Author

wixbot commented May 2, 2014

Originally changed by barnson
Resolution set to merged
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.9 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants