Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency save and load behaviour in WixStdBa #4496

Closed
wixbot opened this issue Aug 10, 2014 · 5 comments
Closed

Inconsistency save and load behaviour in WixStdBa #4496

wixbot opened this issue Aug 10, 2014 · 5 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Aug 10, 2014

File: WixStandardBootstrapperApplication.cpp
Methods: SavePageSettings() and OnChangeState()

The method SavePageSettings() loop through all the checkbox controls, buttons with BS_AUTORADIOBUTTON and editboxes with names and set a Burn variable with that name to the control value. This method is executed for the pages WIXSTDBA_PAGE_INSTALL and WIXSTDBA_PAGE_OPTIONS. The opposite method OnChangeState() reads the Burn variable and set the value to the controls with the same name. Here're some inconsistencies.

  1. The implementation for reading Burn variables and set the value for editboxes is missing. So these values are saved but not loaded.
  2. Reading Burn variables and set the value to the named controls is working for the pages WIXSTDBA_PAGE_INSTALL, WIXSTDBA_PAGE_OPTIONS and WIXSTDBA_PAGE_MODIFY. But saving is working for WIXSTDBA_PAGE_INSTALL and WIXSTDBA_PAGE_OPTIONS only. So values in the modify page are read and shown but not saved.

Originally opened by akerl

@wixbot
Copy link
Author

wixbot commented Aug 10, 2014

Wix 3.9.805.0

Originally posted by akerl

@wixbot
Copy link
Author

wixbot commented Aug 14, 2014

Release changed from v3.9 to v3.x
Type changed from Bug to Feature

@wixbot
Copy link
Author

wixbot commented Feb 9, 2015

Originally changed by rseanhall
AssignedTo set to shall

@wixbot
Copy link
Author

wixbot commented Feb 9, 2015

Pull request: 203

Originally posted by rseanhall
Area changed from burn to extensions
Release changed from v3.x to v3.10

@wixbot
Copy link
Author

wixbot commented Feb 10, 2015

Originally changed by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants