Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyro does not allow "empty" transforms to be added #4543

Closed
wixbot opened this issue Sep 29, 2014 · 6 comments
Closed

Pyro does not allow "empty" transforms to be added #4543

wixbot opened this issue Sep 29, 2014 · 6 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Sep 29, 2014

One of our teams wanted to basically throw any wixmst at pyro and have it ignore transforms that do not include changes. This was easier for their build process than dealing with errors. This was done as an opt-in experience passing the -aet option to pyro.

Originally opened by heaths

@wixbot
Copy link
Author

wixbot commented Sep 29, 2014

Originally changed by heaths
Type changed from Bug to Feature

@wixbot
Copy link
Author

wixbot commented Sep 29, 2014

@wixbot
Copy link
Author

wixbot commented Oct 2, 2014

Not planning to take in v3.x.

Release changed from v3.10 to v4.0

@wixbot
Copy link
Author

wixbot commented Feb 28, 2015

Already pulled into wix3 as 8e5ad8. Rebased PR 49 onto current develop branch and updated the PR on GitHub.

Originally posted by heaths

@wixbot
Copy link
Author

wixbot commented Mar 1, 2015

Per wixtoolset/wix#49, implement this by default and yield a warning if the transform contains no changes (and don't embed it). The warning can then be promoted to an error if builders care.

Originally posted by heaths

@wixbot
Copy link
Author

wixbot commented Nov 30, 2015

Originally changed by heaths
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
@rseanhall rseanhall added this to Done in wix.4.0-preview.0 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants