Heat should escape dollar signs ($$) in file names

[wixbot]

When harvesting the file AuthController$$TestAuthParams.html, heat generates this component:

<File Id="fil50E06941A55A672424B7E311B8A289FC" KeyPath="yes" Source="$(var.WebAppSource)\share\doc\api\controllers\AuthController$$TestAuthParams.html" />

Light interprets the filename as AuthController$TestAuthParams.html, resulting in a LGHT0103 error (file not found).

Heat should instead escape $$ to $$$$ according to the docs:

The preprocessor treats the $ character in a special way if it is followed by a $ or (. If you want to use a literal $$, use $$$$ instead. Every two $ characters will be replaced with one. For example, $$$$$ will be replaced with $$$.

Originally opened by dwickern

[wixbot]

Release changed from v3.8 to v3.x

[wixbot]

Why is this a bug. According to the Quote you used for Reference: Every two $ characters will be replaced with one. The pre-processor is behaving as expected, with respect to the documented behavior. Would it dot be easier to have heat ignore Filenames with special characters. I'll try and tackle this one but implementimg a count of special characters will be tough.

Originally posted by eyoung100

[wixbot]

The preprocessor behaves as expected, the problem is heat. The original file name had two $ characters and heat generated a component with only one $ according do the preprocessor escaping rules.

I opened a PR wixtoolset/wix3#163

Originally posted by dwickern

[wixbot]

Since you submitted a pull request for the $, you should test the other special characters, if there are any.

Originally posted by eyoung100

[wixbot]

wixtoolset/wix3#163

Originally posted by barnson
AssignedTo set to dwickern
Resolution set to fixed
Status changed from Open to Resolved

[wixbot]

Originally changed by barnson
Release changed from v3.x to v3.10