Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn doesn't generate error if package names collide #4574

Closed
wixbot opened this issue Oct 31, 2014 · 2 comments · Fixed by wixtoolset/Core#276
Closed

Burn doesn't generate error if package names collide #4574

wixbot opened this issue Oct 31, 2014 · 2 comments · Fixed by wixtoolset/Core#276

Comments

@wixbot
Copy link

wixbot commented Oct 31, 2014

Burn should generate an error (or, at least a warning) if two packages in a chain are going to embedded with the same filename. Currently, the overall .exe size looks correct (i.e. as if it has both) but only one of the driver.msi files is extracted when dark is run and I'm not sure the installer would work correctly at runtime.

  <Chain>
   <MsiPackage Id="Win7_driver"
               ForcePerMachine="yes"
               SourceFile="Win7\driver.msi"
                Vital="yes" Compressed="yes"
               SuppressSignatureVerification="yes"
               InstallCondition="VersionNT = v6.1 AND NTProductType = 1">
      <MsiProperty Name="INSTALLDIR" Value="[InstallFolder]"/>
    </MsiPackage>

   <MsiPackage Id="Win2008R2_2012_8_driver"
               ForcePerMachine="yes"
               SourceFile="Win8\driver.msi"
               Vital="yes" Compressed="yes"
               SuppressSignatureVerification="yes"
               InstallCondition="VersionNT > v6.1 OR NOT NTProductType = 1">
       <MsiProperty Name="INSTALLDIR" Value="[InstallFolder]"/>
   </MsiPackage>

    <MsiPackage ForcePerMachine="yes"
               SourceFile="utils.msi"
                Vital="yes" Compressed="yes"
                SuppressSignatureVerification="yes">
    </MsiPackage>
  </Chain>

Originally opened by bcran

@wixbot
Copy link
Author

wixbot commented Nov 13, 2014

Release changed from v3.9 to v3.x
Type changed from Bug to Feature

@wixbot
Copy link
Author

wixbot commented May 13, 2015

I ran into this today, and wanted to add some information.

This doesn't break the bundle installation, just dark extraction.

In my case, I was including several vc_redist packages, which have the same filename. The bundle appears to install correctly, and I can see that the appropriate packages show up in the PackageCache.

When dark.exe unpacks the bundle, however, the filenames collide. The package that shows up in the AttachedContainer folder is the last package that was added to the chain, but that could just be a coincidence.

Originally posted by d.andersen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants