Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputName in wixproj can not be parameterized because it's always rewritten #4614

Open
wixbot opened this issue Dec 5, 2014 · 2 comments
Open

Comments

@wixbot
Copy link

wixbot commented Dec 5, 2014

It's impossible to set any predefined name in custom project template based on wixproj file, because of this code in WixProjectNode:
This code does not check whether the OutputName project property is already being set, for example with some MSBuild parameter, like $SomeParameter$
but it's said that it initializes the project properties only if they are empty but there is no actual check if property is empty.
Thanks for such a great project! It can be even more amazing!

    /// <summary>
    /// Initialize common project properties with default value if they are empty.
    /// </summary>
    /// <remarks>
    /// The following common project properties are set to default values: OutputName.
    /// </remarks>
    protected override void InitializeProjectProperties()
    {
        string projectName = Path.GetFileNameWithoutExtension(this.FileName);
        this.SetProjectProperty(WixProjectFileConstants.OutputName, projectName);
    }

Originally opened by lakmus85

@wixbot
Copy link
Author

wixbot commented Dec 11, 2014

Release changed from v3.9 to v3.x

@wixbot
Copy link
Author

wixbot commented Jan 8, 2015

Originally changed by lakmus85
AssignedTo set to lakmus85

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@robmen robmen modified the milestones: v3.x, v.Votive Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants