Minor upgrade doesn't change files if EnableFeatureSelection="yes" in MsiPackage.

[wixbot]

Minor upgrade doesn't change files if EnableFeatureSelection="yes" in MsiPackage.
We use own boostrapper applicationand and control features via OnPlanMsiFeature callback.Files will upgrade only if feature isn't presented in previous setup and is presented in new setup. All other files keep untouched.
I think it's because of when applying minor update REINSTALL property is empty, but must be REINTALL=ALL or REINTALL=<feature to reinstall 1>, ...

Originally opened by sergju

[wixbot]

When EnableFeatureSelection="yes" Burn calls back and you need to specify feature action states. If you're doing that, please reopen the bug and post the Burn log with details.

Release changed from v3.9 to v3.x
Resolution set to bydesign
Status changed from Untriaged to Resolved

[wixbot]

Originally changed by sergju
Resolution changed from bydesign to
Statuschanged fromResolvedtoOpen

[wixbot]

Log files:
Burn log file:
https://www.dropbox.com/s/pbxcqc2fe0y3e18/aBootstrapper1_20141212103807.log

Msi log file:
https://www.dropbox.com/s/h7r88vm8lihd5cb/aBootstrapper1_20141212103807_0_aSetupProject1.log

Removing old burn log file:
https://www.dropbox.com/s/plervotg6hvbgj0/aBootstrapper1_20141212103818.log?dl=0

Originally posted by sergju

[wixbot]

Please post your OnPlanMsiFeature code.

[wixbot]

STDMETHODIMP_(int) OnPlanMsiFeature(__in_z LPCWSTR wzPackageId, __in_z LPCWSTR wzFeatureId, __inout BOOTSTRAPPER_FEATURE_STATE* pRequestedState)
{
BalLog(BOOTSTRAPPER_LOG_LEVEL_STANDARD, "OnPlanMsiFeature, wzPackageId='%ls', wzFeatureId='%ls'", wzPackageId, wzFeatureId);
HRESULT hr;

    BOOL bVal;

    if (SUCCEEDED(hr = EvalConditionVariable(wzFeatureId, bVal)))
    {
        (*pRequestedState) = bVal ? BOOTSTRAPPER_FEATURE_STATE_LOCAL : BOOTSTRAPPER_FEATURE_STATE_ABSENT;
    }

    BalLog(BOOTSTRAPPER_LOG_LEVEL_STANDARD, "returned (*pRequestedState)=%d", (*pRequestedState));
    return IDNOACTION;
}

HRESULT EvalConditionVariable(LPCWSTR wzVariableName, BOOL& bVal)
{
    HRESULT hr;
    LPWSTR szCondition = NULL;

    if (S_OK != (hr = BalGetStringVariable(wzVariableName, &szCondition)))
        ExitWithLastError1(hr, "Variable %ls not found.", wzVariableName);


    if (SUCCEEDED(hr) && szCondition && *szCondition)
    {
        if (!SUCCEEDED(hr = m_pEngine->EvaluateCondition(szCondition, &bVal)))
            ExitWithLastError2(hr, "Enable to evaluate %ls=%ls condition.", wzVariableName, szCondition);
    }
LExit:
    ReleaseStr(szCondition);
    return hr;
}

And in burn log you can see feature state (_pRequestedState) at exit from method.
('returned (_pRequestedState)=3')

Originally posted by sergju

[yordans]

Is this bug going to be fixed soon?

[robmen]

This issue is open and unassigned. That means it is waiting for someone to investigate the root problem, discuss possible solutions to that problem then implement the decided solution.

If you are interested in doing so yourself, our developer documentation provides a great checklist for getting started.

If you are not interested then you are waiting for someone else to become interested. If this issue has been open for a long time then there probably isn't much interest in this particular issue. In that case, you'll want to consider how to motivate others to fix it for you. This is a pretty good list of support options.