Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util:FileShare fails to create a network share for a whole drive (ie root folder) #4646

Closed
wixbot opened this issue Jan 6, 2015 · 4 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Jan 6, 2015

The problem occurs as when a root directory is entered such as "c:" the trailing backlash is removed.
NetShareAdd() called by CreateShare() in scasmbexec.cpp requires this trailing backslash to share the whole drive. However, ScaSmbRead() in scasmbsched.cpp at line 230 removes the trailing backslash even for a root directory:
"// remove trailing backslash"

Originally opened by greggc

@wixbot
Copy link
Author

wixbot commented Jan 8, 2015

Release changed from v3.9 to v3.x

@wixbot
Copy link
Author

wixbot commented Feb 9, 2015

Originally changed by rseanhall
AssignedTo set to shall

@wixbot
Copy link
Author

wixbot commented Feb 9, 2015

3.10 pull request: 205

4.0 pull request: 93

Originally posted by rseanhall
Release changed from v3.x to v3.10

@wixbot
Copy link
Author

wixbot commented Feb 10, 2015

Thanks for locating the problem.

Originally posted by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants