Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MajorUpgrade element does not include ProductLanguage #4663

Closed
wixbot opened this issue Jan 27, 2015 · 4 comments
Closed

MajorUpgrade element does not include ProductLanguage #4663

wixbot opened this issue Jan 27, 2015 · 4 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Jan 27, 2015

As Windows Installer seemed to intend by definition of the Upgrade table, products can have the same UpgradeCode by upgrade versions that have the same ProductLanguage. The MajorUpgrade element - a nice shortcut - does not support adding the ProductLanguage to the Upgrade table (as Upgrade.Language). Making this opt-in would be backward compatible while providing for different-language upgrade isolation.

Opening as a bug since this was actually a problem we found in some of our products that use a language-agnostic UpgradeCode but use the MajorUpgrade element as well. We can work around but this may not be intuitive for newer setup authors.

Originally opened by heaths

@wixbot
Copy link
Author

wixbot commented Jan 27, 2015

Release changed from v4.x to v4.0
Type changed from Bug to Feature

@wixbot
Copy link
Author

wixbot commented Mar 1, 2015

Originally changed by heaths
AssignedTo set to heaths

@wixbot
Copy link
Author

wixbot commented May 10, 2015

Wix4 PR: wixtoolset/wix#128

Originally posted by heaths

@wixbot
Copy link
Author

wixbot commented Jul 6, 2015

Originally changed by heaths
Resolution set to fixed
Status changed from Open to Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants