Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlConfig/@ElementId is not modularized #4698

Closed
wixbot opened this issue Mar 9, 2015 · 1 comment
Closed

XmlConfig/@ElementId is not modularized #4698

wixbot opened this issue Mar 9, 2015 · 1 comment
Assignees
@robmen
Labels
bug extensions FourOhPreviewZero
Projects
wix.4.0-preview.0
Milestone
v4.0

Comments

@wixbot
Copy link

wixbot commented Mar 9, 2015

The ElementId attribute does not work when using XmlConfig in a merge module.

When looking with orcas the element ID has not been modularized (it does not have the module GUID stuck on the end of it), so it does not match the correct id, and fails at runtime.

Originally opened by oliverhallam
@wixbot
Copy link
Author

wixbot commented Mar 10, 2015

Release changed from v4.x to v4.0

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@rseanhall rseanhall added this to To do in wix.4.0-preview.0 Nov 16, 2020
robmen added a commit to wixtoolset/Util.wixext that referenced this issue Jan 9, 2021
@robmen
Modularize XmlConfig/@ElementId and add tests for XmlConfig
af1516e 
Fixes wixtoolset/issues#4698
Closes wixtoolset/issues#5447
wix.4.0-preview.0 automation moved this from To do to Done Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

Labels
bug extensions FourOhPreviewZero
Projects
No open projects
wix.4.0-preview.0
  
Done
Milestone
v4.0
Development

No branches or pull requests
3 participants
@robmen @barnson @wixbot