ParseTypeLibElement MinorVersion maximum value check

[wixbot]

Hi,

I noticed in ParseTypeLibElement, WIX uses byte.MaxValue to check the range, however from Microsoft, minor version can be a 16bit value which is the same as MajorVersion

minor-value
Specifies a short unsigned integer between zero and 65,535

I assume it needs to be changed to ushort.MaxValue?

https://msdn.microsoft.com/en-us/library/windows/desktop/aa367306(v=vs.85).aspx

minorVersion = this.core.GetAttributeIntegerValue(sourceLineNumbers, attrib, 0, byte.MaxValue);

Thanks
Jim

Originally opened by jim

[wixbot]

AssignedTo set to bobarnson
Release changed from v3.9 to v3.10

[wixbot]

https://msdn.microsoft.com/en-us/library/aa372092%28v=vs.85%29.aspx says

Version

This is the version of the library. The major and minor versions are encoded in the four byte integer value. The minor version is in the lower eight bits. The major version is in the middle sixteen bits.

which explains the current implementation.

Recommend wontfix.

Originally posted by barnson
Status changed from Open to Untriaged

[wixbot]

Non-advertised should support 16-bit range. Advertised cannot.

Release changed from v3.10 to v4.0

[cpuwzd]

I'm looking at this issue. I think I can fix the bug, but I don't know where to put failing test(s) for Compiler.Package or Compiler.
If I need to build new structure, what would the fixture be named and where would the file fit in the hierarchy?

Ron

[robmen]

Compiler tests mostly live here: https://github.com/wixtoolset/wix4/tree/develop/src/wix/test/WixToolsetTest.CoreIntegration

[barnson]

I'll take a look at your pull request.

[cpuwzd]

Thanks!

…

On 6/10/2021 2:10 PM, Bob Arnson wrote: I'll take a look at your pull request. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4726 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHIYUBRBMWNXSH2WBPXWCHTTSD52JANCNFSM45L5SQIA>.