Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting bal:Overridable to 'yes' throws an exception #4736

Closed
wixbot opened this issue Apr 12, 2015 · 3 comments · Fixed by wixtoolset/Bal.wixext#27
Closed

Setting bal:Overridable to 'yes' throws an exception #4736

wixbot opened this issue Apr 12, 2015 · 3 comments · Fixed by wixtoolset/Bal.wixext#27

Comments

@wixbot
Copy link

wixbot commented Apr 12, 2015

Trying to compile

<Variable Name="Test1" bal:Overridable="yes" />

crashes candle. As this code was modified as part of a larger change (switching to XDocument), all extensions modified in the pull request should be looked at.

candle.exe : error CNDL0001: Cannot set string column 'Name' with a value of type 'System.Xml.Linq.XAttribute'. [path\to\Bundle.wixproj]

  Exception Type: System.InvalidOperationException

  Stack Trace:
     at WixToolset.Data.ColumnDefinition.ValidateValue(Object value)
         in src\libs\WixToolset.Data\ColumnDefinition.cs:line 989
     at WixToolset.Data.Field.set_Data(Object value)
         in src\libs\WixToolset.Data\Field.cs:line 53
     at WixToolset.Data.Row.set_Item(Int32 field, Object value)
         in src\libs\WixToolset.Data\Row.cs:line 154
     at WixToolset.Extensions.BalCompiler.ParseAttribute(XElement parentElement, XAttribute attribute, IDictionary`2 context)
         in src\ext\BalExtension\wixext\BalCompiler.cs:line 206
     at WixToolset.CompilerCore.ParseExtensionAttribute(XElement element, XAttribute attribute, IDictionary`2 context) 
         in src\tools\wix\CompilerCore.cs:line 1454
     at WixToolset.Compiler.ParseVariableElement(XElement node)
         in src\tools\wix\Compiler.cs:line 20340
     at WixToolset.Compiler.ParseBundleElement(XElement node)
         in src\tools\wix\Compiler.cs:line 18139
     at WixToolset.Compiler.ParseWixElement(XElement node)
         in src\tools\wix\Compiler.cs:line 20455
     at WixToolset.Compiler.Compile(XDocument source)
         in src\tools\wix\Compiler.cs:line 195
     at WixToolset.Tools.Candle.Run()
         in src\tools\candle\candle.cs:line 201
     at WixToolset.Tools.Candle.Execute(String[] args)
         in src\tools\candle\candle.cs:line 76

Originally opened by rseanhall

@wixbot
Copy link
Author

wixbot commented Apr 14, 2015

AssignedTo set to firegiant

@janilemy
Copy link

janilemy commented Feb 4, 2019

This is still an issue on v4.0.0.5918 but it is working in version 3.x

@robmen
Copy link
Member

robmen commented Feb 4, 2019

@janilemy that's good. The issue is still open against v4.0 which means it hasn't been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants