Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed custom actions in daily builds #4746

Open
wixbot opened this issue Apr 23, 2015 · 2 comments
Open

Managed custom actions in daily builds #4746

wixbot opened this issue Apr 23, 2015 · 2 comments
Labels
bug website Issues related to updating the WiX Toolset's website
Milestone

Comments

@wixbot
Copy link

wixbot commented Apr 23, 2015

If you follow the steps to integrate WiX projects into daily builds and do not install WiX on your build machines, you will not be able to build custom action projects as the path to MakeSfxCA.exe will be incorrect.

The problem is the _SetDefaultPathValues target in Wix.CA.targets. It sets WixSdkPath to $(WixToolPath)..\sdk\.

On a machine with WiX installed on it, WixToolPath would be set to something like C:\Program Files (x86)\WiX Toolset v3.9\bin\. Notice bin at the end. This is important. In C:\Program Files (x86)\WiX Toolset v3.9\ you have bin and sdk subdirectories, so that works fine.

However, if you follow those instructions and point WixToolPath to where you unpacked wix*-binaries.zip to, you don't have a bin subdirectory; everything that would be there is just in that directory. There is still an sdk subdirectory. When _SetDefaultPathValues sets WixSdkPath, it sets it to a path that likely doesn't exist (again, that's $(WixToolPath)..\sdk\). Finally, this results in being unable to run MakeSfxCA.exe in the PackCustomAction target because the path doesn't exist.

This can be fixed by doing one of the following:

  • Move the binaries from the root of the directory wix*-binaries.zip was unpacked to to a freshly created bin subdirectory
  • Including adding this in the PropertyGroup section with the other properties in the instructions: <WixSdkPath>$(WixToolPath)sdk\</WixSdkPath>

You may also want to add <WixCATargetsPath>$(WixSdkPath)Wix.CA.targets</WixCATargetsPath> so the file from the installed version of WiX (if there is one) isn't used.

Originally opened by dcormier

@wixbot
Copy link
Author

wixbot commented Apr 28, 2015

Release changed from v3.9 to v3.x

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@dcormier
Copy link

The link that reads, "the steps to integrate WiX projects into daily builds" originally went here before this was moved from the WiX website to GitHub. Unfortunately, I can't edit it to correct it.

@robmen robmen added website Issues related to updating the WiX Toolset's website and removed wixtoolset.org labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug website Issues related to updating the WiX Toolset's website
Projects
None yet
Development

No branches or pull requests

3 participants