Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor choice of MediaTemplate/@CabinetTemplate can result in the cab file being written to a COM port #4797

Closed
wixbot opened this issue Jun 13, 2015 · 2 comments
Closed

Poor choice of MediaTemplate/@CabinetTemplate can result in the cab file being written to a COM port #4797

wixbot opened this issue Jun 13, 2015 · 2 comments
Assignees
@robmen
Labels
feature linker
Milestone
v3.11

Comments

@wixbot
Copy link

wixbot commented Jun 13, 2015

Writing cabinet files does not appear to check the resulting device is actually a file. For example if you declare <MediaTemplate CabinetTemplate="Com{0}.cab"> and you have communication port COM1 present on your PC, the entire cabinet file is written to the communication port COM1.

Originally opened by rbradford
@wixbot
Copy link
Author

wixbot commented Jun 16, 2015

AssignedTo set to robmen
Release changed from v3.9 to v3.11

@wixbot
Copy link
Author

wixbot commented Jun 17, 2015

Type changed from Bug to Feature

@wixbot wixbot added this to the v3.11 milestone Dec 20, 2015
@robmen robmen mentioned this issue Feb 1, 2017
Merged
rseanhall pushed a commit to rseanhall/wix4-archive that referenced this issue Feb 19, 2017
@robmen @rseanhall
Protect against use of reserved file names
106e02c 
Windows has a set of reserved file names such as `CON`, `NUL`, `COM1`,
`LPT2`. Creating files with those names will result in all sorts of
undesirable behavior, the most common is that that the build hangs.
Now we'll catch use of reserved names and print out a helpful error
message.

Fixes wixtoolset/issues#4797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

Labels
feature linker
Projects
None yet
Milestone
v3.11
Development

No branches or pull requests
2 participants
@robmen @wixbot