You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My CA (in my WixExtension) calls QuietExec, however after installing Wix 3.10.0.1823 I get a conpile error which reports that QuietExec does not take two arguments. Generally I would avoid launching a exe from a CA, but in this situation I need to use a Windows system tool, for which a programing API is not available. The CA was implemented a couple of years ago when using wix 3.7 and has been stable until this change.)
I did not recall hearing about a breaking change within 3.10.0.1823 relative to earlier builds. When I compare the implementation between 1502 and 1823 if seems like this change was made to allow a particular call to QuietExec to disable logging even it was generally enabled. Is this a situation where the use of optional arguments would avoid breaking existing code?
HRESULT WIXAPI QuietExec(
__inout_z LPWSTR wzCommand,
__in DWORD dwTimeout,
__in BOOL fLogCommand = TRUE,
__in BOOL fLogOutput = TRUE
);
(While I subscribed to the new lists, I have not figured out how to view threads or search the new lists, so I don't know if there is already a discussion on this issue..)
Originally opened by phogland
The text was updated successfully, but these errors were encountered:
Technically, all the DUtil functions are C linkage so we can't use default arguments. (Even though most people compile their C with C++ compilers.) Still, it's easy to create wrapper functions and keep all languages happy.
My CA (in my WixExtension) calls QuietExec, however after installing Wix 3.10.0.1823 I get a conpile error which reports that QuietExec does not take two arguments. Generally I would avoid launching a exe from a CA, but in this situation I need to use a Windows system tool, for which a programing API is not available. The CA was implemented a couple of years ago when using wix 3.7 and has been stable until this change.)
wcautil.h for 3.10.0.1502 has:
HRESULT WIXAPI QuietExec(
__inout_z LPWSTR wzCommand,
__in DWORD dwTimeout
);
wcautil.h for 3.10.0.1823 has:
HRESULT WIXAPI QuietExec(
__inout_z LPWSTR wzCommand,
__in DWORD dwTimeout,
__in BOOL fLogCommand,
__in BOOL fLogOutput
);
I did not recall hearing about a breaking change within 3.10.0.1823 relative to earlier builds. When I compare the implementation between 1502 and 1823 if seems like this change was made to allow a particular call to QuietExec to disable logging even it was generally enabled. Is this a situation where the use of optional arguments would avoid breaking existing code?
HRESULT WIXAPI QuietExec(
__inout_z LPWSTR wzCommand,
__in DWORD dwTimeout,
__in BOOL fLogCommand = TRUE,
__in BOOL fLogOutput = TRUE
);
(While I subscribed to the new lists, I have not figured out how to view threads or search the new lists, so I don't know if there is already a discussion on this issue..)
The text was updated successfully, but these errors were encountered: