Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden persisted variables are written to the state file in plaintext #4862

Closed
wixbot opened this issue Aug 18, 2015 · 2 comments · Fixed by wixtoolset/Core#203
Closed

Hidden persisted variables are written to the state file in plaintext #4862

wixbot opened this issue Aug 18, 2015 · 2 comments · Fixed by wixtoolset/Core#203
Assignees
@rseanhall
Labels
bug burn compiler
Projects
wix.4.0-preview.0
Milestone
v4.0

Comments

@wixbot
Copy link

wixbot commented Aug 18, 2015

When persisting variables to the state file, Burn doesn't do anything to try to obscure the values of hidden variables.

Originally opened by rseanhall
@wixbot
Copy link
Author

wixbot commented Aug 18, 2015

CryptoAPI to encrypt the data with the machine key.

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@rseanhall
Copy link
Contributor

As part of the design discussion for #3704, we decided to not allow a variable to be Hidden and Persisted in v4.

@rseanhall rseanhall modified the milestones: v3.x, v4.0 Oct 18, 2020
@rseanhall rseanhall self-assigned this Dec 19, 2020
@rseanhall rseanhall mentioned this issue Dec 20, 2020
Merged
@rseanhall rseanhall added this to Done in wix.4.0-preview.0 Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rseanhall rseanhall

Labels
bug burn compiler
Projects
No open projects
wix.4.0-preview.0
  
Done
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

4862 - Disallow Burn Variables that are Hidden and Persisted rseanhall/Core
2 participants
@rseanhall @wixbot