Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WixStdBA doesn't format the variable's value in editbox #4863

Closed
wixbot opened this issue Aug 18, 2015 · 1 comment · Fixed by wixtoolset/dutil#18
Closed

WixStdBA doesn't format the variable's value in editbox #4863

wixbot opened this issue Aug 18, 2015 · 1 comment · Fixed by wixtoolset/dutil#18

Comments

@wixbot
Copy link

wixbot commented Aug 18, 2015

WixStdBA (and thmutil in WiX 4) loads editboxes with the variable's unformatted value, so if the editbox is tied to the custom Variable TargetMachine and the default value is [ComputerName], then [ComputerName] is put into the editbox instead of the actual computer name. Since WixStdBA (and thmutil in WiX 4) sets the variable without escaping the value (the user could type in a different variable, like [SomeOtherVariable]), I'm not sure what is the right thing to do.

Originally opened by rseanhall

@wixbot
Copy link
Author

wixbot commented Aug 18, 2015

In v3, we don't format. In v4 we'd want literal value support so we can handle both cases.

Release changed from v3.10 to v4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants