Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wixstdba does not compensate for borders and/or title bar size when creating the main window #4906

Closed
wixbot opened this issue Sep 23, 2015 · 1 comment · Fixed by wixtoolset/dutil#12

Comments

@wixbot
Copy link

wixbot commented Sep 23, 2015

Wixstdba allows for configuring the window size using the theme file. However, when wixstdba creates the main window the window size from the theme file is used as is without compensating for border size and/or window title bar size. This in turn means that the actual size of the client region of the main install window will vary from one machine to another and may cause the themed installer to look ugly on some configurations.

To verify this behavior, go to Control Panel -> Display and vary the size of the text size for title bars. (Tested on Windows 8.1).

The fix should probably be to call AdjustWindowRectEx to adjust the window size prior to calling CreateWindowExW in CWixStandardBootstrapperApplication:CreateMainWindow (src/ext/BalExtension/wixstdba/WixStandardBootStrapperApplication.cpp).

For reference see the implementation of CWnd::CalcWindowRect in MFC.

Originally opened by villintehaspam

@wixbot
Copy link
Author

wixbot commented Sep 29, 2015

Release changed from v3.10 to v4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants