Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot bind transforms without files #4912

Closed
wixbot opened this issue Sep 27, 2015 · 3 comments · Fixed by wixtoolset/Core#235
Closed

Cannot bind transforms without files #4912

wixbot opened this issue Sep 27, 2015 · 3 comments · Fixed by wixtoolset/Core#235
Assignees
@robmen
Labels
bug FourOhPreviewZero linker
Projects
wix.4.0-preview.0
Milestone
v4.0

Comments

@wixbot
Copy link

wixbot commented Sep 27, 2015

Seems whatever refactoring was done completely broke patching if trying to build patches without files. The problem starts in BindDatabaseCommand when it calls into GetFileFacadesCommand that assumes the patch has a File and WixFile table.

Originally opened by heaths
@wixbot
Copy link
Author

wixbot commented Sep 27, 2015

Running tests may have caught this - though only bundle tests. Then again, none of the test data source files even have the right schema.

Originally posted by heaths

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@rseanhall rseanhall added this to Needs investigation in wix.4.0-preview.0 Nov 16, 2020
@rseanhall
Copy link
Contributor

If I'm understanding this correctly, this was confirmed fixed in wixtoolset/Core#218.

@robmen
Copy link
Member

robmen commented Mar 2, 2021

I think you are correct. I also added an explicit test that verifies the scenario does work.

robmen added a commit to wixtoolset/Core that referenced this issue Mar 3, 2021
@robmen
Add test to verify patches without files work
7ce6db3 
Resolves wixtoolset/issues#4912
@robmen robmen mentioned this issue Mar 3, 2021
Merged
wix.4.0-preview.0 automation moved this from Needs investigation to Done Mar 3, 2021
robmen added a commit to wixtoolset/Core that referenced this issue Mar 3, 2021
@robmen
Add test to verify patches without files work
e362f93 
Resolves wixtoolset/issues#4912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

Labels
bug FourOhPreviewZero linker
Projects
No open projects
wix.4.0-preview.0
  
Done
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Complete MOVE_TO_BACKEND code migration wixtoolset/Core
4 participants
@robmen @barnson @rseanhall @wixbot