Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for msi package EmbeddedUI #4921

Closed
wixbot opened this issue Oct 7, 2015 · 4 comments
Closed

Support for msi package EmbeddedUI #4921

wixbot opened this issue Oct 7, 2015 · 4 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Oct 7, 2015

This is related to http://wixtoolset.org/issues/4918/.

Burn doesn't support (or incompatible with) WiX EmbeddedUI concept. Please consider adding support for this MSI feature.

Without this feature the DisplayInternalUI attribute documentation
"Specifies whether the bundle will show the UI authored into the msi package." is actually inaccurate.

EmbededUI is a legitimate MSI technique for authoring the UI into msi packages and yet DisplayInternalUI attribute has no effect on it.

Originally opened by taras

@wixbot
Copy link
Author

wixbot commented Oct 7, 2015

To be fair, "Internal UI" means the UI that MSI displays based on the Dialog and Control tables. "Embedded UI" is the UI that is displayed via the MsiEmbeddedUI table. The attribute is called DisplayInternalUI because it can display Internal UI (although that has a few issues as well) not Embedded UI.

Originally posted by robmen

@wixbot
Copy link
Author

wixbot commented Oct 7, 2015

OK, I agree with the technicalities. But... the doc doesn't mention neither of MSI tables. What it's saying is "UI authored into the msi package". Thus it does't appeal to the MSI schema but uses general purpose terminology "authorized into", which does in fact cover "Embedded UI".

Also doc does not indicate that "Embedded UI" is not supported or even handled differently comparing to standard UI. It got me into the trap and had cost me quite some time to investigate until I was convinced there is nothing wrong with my code. :(


Anyway is there any chance that it can be implemented?

This interesting discussion suggests (Christoffel le Roux message: Aug 22, 2012; 7:17pm) that any alternative work around is impossible but the fix may be reasonable simple (spacial handling of CLIENUILEVEL) but needs Burn code change. However it's hard for me to judge if it is indeed the case.

Originally posted by taras

@wixbot
Copy link
Author

wixbot commented Oct 13, 2015

Might not be feasible given how Burn works as an external UI handler. Needs research and a WIP.

@rseanhall
Copy link
Contributor

Burn now supports this in v4.0 through #6164. wixstdba doesn't support EmbeddedUI, but there are plans for a new built-in BA that will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants