Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt key in wixstdba messes up the foreground/background of controls #4931

Closed
wixbot opened this issue Oct 20, 2015 · 6 comments
Closed

Alt key in wixstdba messes up the foreground/background of controls #4931

wixbot opened this issue Oct 20, 2015 · 6 comments

Comments

@wixbot
Copy link

wixbot commented Oct 20, 2015

Problem occurs if we have image on page, controls over it and Alt(+Click) pressed.

What happend when the ALT key pressed:
Window contorls styles must be highlighted by undrelining access key (for access by Alt+).
If we have owner-draw controls (such as image) on the page they are always redrawn if ALT pressed via receiving WM_DRAWITEM. Controls without SS_OWNERDRAW does not do this. Therefore, their background is erased.

Code to reproduce:

<Theme xmlns="http://wixtoolset.org/schemas/thmutil/2010" ImageFile="bg.png">
  <Window Width="614" Height="415" HexStyle="100a0000" FontId="0" SourceX="0" SourceY="0">#(loc.Caption)</Window>
  <Page Name="Help">
    <Image X="0" Y="0" Width="614" Height="415" ImageFile="bgClear.png"/>
    <Text X="25" Y="85" Width="-25" Height="32" FontId="1" DisablePrefix="yes">#(loc.HelpHeader)</Text>
    <Text X="25" Y="120" Width="-25" Height="-101" FontId="3" DisablePrefix="yes">#(loc.HelpText)</Text>
    <Button Name="HelpCancelButton" X="-25" Y="-35" Width="103" Height="23" TabStop="yes" FontId="0" DisablePrefix="yes">#(loc.HelpCloseButton)</Button>
  </Page>

Originally opened by pavelanfimov

@wixbot
Copy link
Author

wixbot commented Oct 20, 2015

The situation are the same as discribed here

Originally posted by pavelanfimov

@wixbot
Copy link
Author

wixbot commented Oct 20, 2015

see pullrequest wixtoolset/wix3#309

Originally posted by pavelanfimov

@wixbot
Copy link
Author

wixbot commented Oct 20, 2015

Originally changed by pavelanfimov
Resolution set to open

@wixbot
Copy link
Author

wixbot commented Oct 20, 2015

Originally changed by pavelanfimov
Resolution changed from open to

@wixbot
Copy link
Author

wixbot commented Oct 23, 2015

Release changed from v3.10 to v3.x

@drolevar
Copy link

drolevar commented Feb 9, 2021

@rseanhall
This fix has been accepted in to wix4 branch: wixtoolset/dutil#24.
Since it's been an annoying issue for a lot of people it might be a good idea to accept it into wix3: wixtoolset/wix3#527

@rseanhall rseanhall modified the milestones: v3.x, v4.0 Feb 9, 2021
@rseanhall rseanhall added this to In progress in wix.4.0-preview.0 Feb 9, 2021
@rseanhall rseanhall moved this from In progress to Done in wix.4.0-preview.0 Feb 19, 2021
@rseanhall rseanhall modified the milestones: v4.0, v3.14 Feb 23, 2021
@rseanhall rseanhall removed the triage label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants