Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WixSqlExtension de localized strings are in the WixUIExtension, not accessible so far as I could tell. #4932

Closed
wixbot opened this issue Oct 20, 2015 · 4 comments
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Oct 20, 2015

I am in the process of adding the WixSqlExtension to a msi package in my bundle which installs SQL Server Express first, then runs this msi package. I support a number of locals, and I get compile errors, as expected, until I add the WixSqlExtension related strings to my wxl files, for the locals that the WixSqlExtension does not provide translations. The curious thing that I noticed is that in Wix 3.10.0.2103 the de-DE SqlExtension related strings are translated and included in the WixUIExtension. (Search wix source for msierrFailedCreateDatabase, or a related string ID.)

I tried briefly to add the Wix UIExtension to my project, even though I don’t use the Wix UI, but this did not resolve the link errors:
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(23,0): error LGHT0102: The localization variable !(loc.ConfigureSql) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(24,0): error LGHT0102: The localization variable !(loc.ConfigureSql) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(25,0): error LGHT0102: The localization variable !(loc.CreateDatabase) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(26,0): error LGHT0102: The localization variable !(loc.DropDatabase) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(27,0): error LGHT0102: The localization variable !(loc.ExecuteSqlStrings) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(28,0): error LGHT0102: The localization variable !(loc.RollbackExecuteSqlStrings) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(17,0): error LGHT0102: The localization variable !(loc.msierrSQLFailedCreateDatabase) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(18,0): error LGHT0102: The localization variable !(loc.msierrSQLFailedDropDatabase) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(19,0): error LGHT0102: The localization variable !(loc.msierrSQLFailedConnectDatabase) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(20,0): error LGHT0102: The localization variable !(loc.msierrSQLFailedExecString) is unknown. Please ensure the variable is defined.
C:\agent_work\eca3d12b\wix3\src\ext\SqlExtension\wixlib\SqlExtension.wxs(21,0): error LGHT0102: The localization variable !(loc.msierrSQLDatabaseAlreadyExists) is unknown. Please ensure the variable is defined.

Adding these strings to my de .wxl file does resolve the errors, even though they are already translated in the wix source. I point this out because it seems like de localized strings for SqlExtension are in the wrong place in the wix source and not useable (at least in my brief test).

Phill

Originally opened by phogland

@wixbot
Copy link
Author

wixbot commented Oct 23, 2015

de-de strings need to be distributed to the various extension wixlibs.

Release changed from v3.10 to v3.x

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@MarcSchaetz
Copy link

Hello, I would like to work on the localization of WixSqlExtension.

@rseanhall
Copy link
Contributor

@MarcSchaetz Thanks for volunteering! In order to assign you this bug, I have to add you as a collaborator to this repo. Look for a confirmation email from GitHub for this. Also, make sure to check out our development page for how to get started.

@rseanhall
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants