Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation bug #4946

Closed
wixbot opened this issue Nov 3, 2015 · 1 comment
Closed

Documentation bug #4946

wixbot opened this issue Nov 3, 2015 · 1 comment
Labels
bug
Milestone
v3.11

Comments

@wixbot
Copy link

wixbot commented Nov 3, 2015

The sample program that generates GUIDs is functionally correct, but it is badly written and has a memory leak.
I'm referring to this program: https://www.firegiant.com/system/files/samples/uuidgen.c

  • wstrGUID is an array of 100 pointers. In effect, the program only use the first pointer
  • You need to free the memory allocated by StringFromCLSID with CoTaskMemFree
  • It would be more "correct" to call StringFromGUID2, although the same result
  • better use sizeof(strGUID) instead of MAX_PATH, which is wrong (although the required string is smaller than 100).

Originally opened by uri247
@wixbot
Copy link
Author

wixbot commented Nov 6, 2015

This isn't a WiX bug; we'll tell FireGiant about it.

Resolution set to external
Status changed from Untriaged to Resolved

@wixbot wixbot added this to the v3.11 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.11
Development

No branches or pull requests
1 participant
@wixbot