Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparently unnecessary duplicated #define statements #4966

Open
wixbot opened this issue Nov 17, 2015 · 3 comments
Open

Apparently unnecessary duplicated #define statements #4966

wixbot opened this issue Nov 17, 2015 · 3 comments

Comments

@wixbot
Copy link

wixbot commented Nov 17, 2015

In the ComPlusExtension.file:
wix3.10.0.2101\src\ext\ComPlusExtension\ca\cpsched\cpsched.cpp has a list of #define statements which repeat themselves for no apparent reason (and probably no harm).

'#define CP_COMPLUSROLLBACKINSTALLPREPARE L"ComPlusRollbackInstallPrepare_64"

'#define CP_COMPLUSINSTALLPREPARE L"ComPlusInstallPrepare_64"

'#define CP_COMPLUSROLLBACKINSTALLEXECUTE L"ComPlusRollbackInstallExecute_64"

'#define CP_COMPLUSINSTALLEXECUTE L"ComPlusInstallExecute_64"

'#define CP_COMPLUSINSTALLEXECUTECOMMIT L"ComPlusInstallExecuteCommit_64"

'#define CP_COMPLUSINSTALLCOMMIT L"ComPlusInstallCommit_64"

Notice these are mostly the same as above.
'#define CP_COMPLUSROLLBACKINSTALLPREPARE L"ComPlusRollbackInstallPrepare_64"

'#define CP_COMPLUSINSTALLPREPARE L"ComPlusInstallPrepare_64"

'#define CP_COMPLUSROLLBACKUNINSTALLEXECUTE L"ComPlusRollbackUninstallExecute_64"

'#define CP_COMPLUSUNINSTALLEXECUTE L"ComPlusUninstallExecute_64"

'#define CP_COMPLUSINSTALLCOMMIT L"ComPlusInstallCommit_64"

There is also a not _WIN64 block which is understandable but the same duplicated #define statements are repeated there as well.

Originally opened by phogland

@wixbot
Copy link
Author

wixbot commented Nov 17, 2015

Big Sorry! Really dumb of me! Just delete this nonsense!

Originally posted by phogland

@wixbot
Copy link
Author

wixbot commented Nov 19, 2015

CP_COMPLUSINSTALLPREPARE is repeated.

Originally posted by barnson

@wixbot
Copy link
Author

wixbot commented Nov 20, 2015

Release changed from v3.10 to v3.x

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant