Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure handling of hidden variable command line parameters #5079

Closed
wixbot opened this issue Dec 9, 2015 · 1 comment
Closed

Insecure handling of hidden variable command line parameters #5079

wixbot opened this issue Dec 9, 2015 · 1 comment
Labels

Comments

@wixbot
Copy link

wixbot commented Dec 9, 2015

In Wix 3.10, a bugfix was made:
http://wixtoolset.org/issues/4731/ (#4731)
that obfuscated the values of hidden bundle variables. I appreciated that very much.

However, since passing sensitive information is considered a valid use case, it would be even better if hidden bundle variable values were stored and passed to the custom bootstrapper application as SecureStrings. By doing so, a user would not have to deal with having its sensitive information available in process memory as plain text.

Currently, all command line args are available by:
Command.GetCommandLineArgs()

My proposal is to remove any hidden bundle variable from there and add it to a separate method such as:
Command.GetHiddenCommandLineArgs()

Since such a change would break the current behavior, I would suggest it for the 4.0 track.
It is hard for me to determine if this is a bug or a feature request.

Originally opened by lillegard

@wixbot
Copy link
Author

wixbot commented Dec 18, 2015

Command lines aren't secure -- any user can read the command lines of other processes in the same integrity level.

Resolution set to declined
Status changed from Untriaged to Resolved

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
@rseanhall rseanhall removed this from the v4.0 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants