Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use MSIs as source of files during patch build #6401

Closed
robmen opened this issue Mar 26, 2021 · 1 comment · Fixed by wixtoolset/wix#250
Closed

WIP: Use MSIs as source of files during patch build #6401

robmen opened this issue Mar 26, 2021 · 1 comment · Fixed by wixtoolset/wix#250
Assignees
Labels
patching wip WiX Improvement Proposal
Milestone

Comments

@robmen
Copy link
Member

robmen commented Mar 26, 2021

  • Describe the scenario and benefits that the feature supports.

Windows Installer patches (.msp) are created by diff'ing a baseline MSI with an updated MSI. This diffing process requires not only the two MSI databases but all the source files to calculate differences (especially for delta patching). It turns out the shipping MSI packages have all the files needed, so the tooling could us that.

  • Describe how you're accomplishing the feature today (if possible).

In v3, melt.exe could be used to extract the files from MSI packages and update the .wixpdb to point at those locations. This provides a pretty good experience for making all the files available. But it is "yet another .exe" required to be run to execute patching in v3.

  • Describe what you'd like the new feature to do.

With the integrated patch pipeline in v4, it would be easier if the functionality of melt.exe could be incorporated into the process to create a seamless experience for creating patches by sourcing the files from the MSI files.

@robmen robmen added patching triage wip WiX Improvement Proposal labels Mar 26, 2021
@barnson barnson removed the triage label Apr 1, 2021
@barnson barnson added this to the v4.0 milestone Apr 1, 2021
@barnson barnson added this to To do in wix.4.0-preview.1 via automation Aug 5, 2021
@barnson barnson changed the title WIP: Source files from MSIs during patching WIP: Use MSIs as source of files during patch build Aug 5, 2021
@rseanhall
Copy link
Contributor

There are multiple Burn integration tests to update as part of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patching wip WiX Improvement Proposal
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants