Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improved patch filtering #6402

Closed
robmen opened this issue Mar 26, 2021 · 3 comments · Fixed by wixtoolset/wix#254 or wixtoolset/web#93
Closed

WIP: Improved patch filtering #6402

robmen opened this issue Mar 26, 2021 · 3 comments · Fixed by wixtoolset/wix#254 or wixtoolset/web#93
Assignees
Labels
patching wip WiX Improvement Proposal
Milestone

Comments

@robmen
Copy link
Member

robmen commented Mar 26, 2021

  • Describe the scenario and benefits that the feature supports.

Pure-WiX patching filtering can work well if the original .wxs code is split into small patch appropriate Fragments. Unfortunately, such Fragments rarely represent a logical grouping of installation functionality. Developers are often surprised that patch filtering happens at the section level rather than logical grouping of Features and Components, etc.

  • Describe how you're accomplishing the feature today (if possible).

The Unbinder actually provides a system for logically grouping Rows to be patched by CustomAction, Feature, Component, File, RegistryKey, ODBC, etc. This mechanism matches the typical developer expectations for filtering.

  • Describe what you'd like the new feature to do.

Adopt the Unbinder's filtering mechanism instead of the section-based patch filtering found in v3.

@robmen robmen added patching triage wip WiX Improvement Proposal labels Mar 26, 2021
@barnson barnson removed the triage label Apr 1, 2021
@barnson barnson added this to the v4.0 milestone Apr 1, 2021
@barnson barnson added this to To do in wix.4.0-preview.1 via automation Aug 5, 2021
@rseanhall
Copy link
Contributor

There is a Burn integration test that needs to be updated with this.

@robmen robmen assigned barnson and robmen and unassigned robmen and barnson Aug 8, 2022
@robmen
Copy link
Member Author

robmen commented Aug 27, 2022

Also, evaluate if this addresses #2689.

@robmen
Copy link
Member Author

robmen commented Sep 22, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patching wip WiX Improvement Proposal
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants