Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn 3.x assumes that installed detect-only related packages that don't match upgrade code are always major upgrades #4756

Closed
wixbot opened this issue May 9, 2015 · 3 comments
Milestone

Comments

@wixbot
Copy link

wixbot commented May 9, 2015

Not the burn engine's fault, the 3.x binder lies to the engine. The 4.x binder doesn't lie, so this particular bug doesn't afflict that branch.

It seems that the 3.x binder wanted to make sure that "unrelated" related packages would never be detected as downgrades, so it forces the OnlyDetect flag in the engine's manifest to "no", which the engine interprets as "major upgrade". As a consequence, I have to record in my BA the upgrade code for each and every MSI package, so that I can filter the incorrect information that the engine feeds to my BA.

Originally opened by bmurri

@wixbot
Copy link
Author

wixbot commented May 10, 2015

The original bug is http://wixtoolset.org/issues/3643/. I think there was concern about custom BA's relying on the current 3.x behavior so the change was only made v4.0.

Originally posted by rseanhall

@wixbot
Copy link
Author

wixbot commented May 19, 2015

http://wixtoolset.org/issues/3643/

Taken in v4.0. Can't really take in v3.x, I think.

Resolution set to duplicate
Status changed from Untriaged to Resolved

@wixbot
Copy link
Author

wixbot commented May 22, 2015

FYI, the Upgrade Code (among other useful information) was put into BootstrapperApplicationData.xml in v3.9 so you shouldn't have to hardcode them in your BA.

Originally posted by rseanhall

@wixbot wixbot added this to the v3.9 milestone Dec 20, 2015
@wixbot wixbot closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant