Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedUI hosting doesn't respect "*.config" embedded by MakeSfxCA.exe #4891

Closed
wixbot opened this issue Sep 15, 2015 · 6 comments
Closed
Milestone

Comments

@wixbot
Copy link

wixbot commented Sep 15, 2015

With WiX v3.10.0.2103 (and earlier) the EmbeddedUI is always hosted by CLR v2.0 even if CLR v4.0 is present on the target system and the embedded app.config properly maps the CLR versions.

Note the test-case I have prepared (TestCase.7z) demonstrates how two assemblies (EmbeddedUI and CustomAction) built and packed the same way are hosted by different CLRs within the same setup at runtime.

The instructions on how to run the test-case are in the readme.txt (form the TestCase.7z package).

Image Text

Originally opened by taras

@wixbot
Copy link
Author

wixbot commented Sep 15, 2015

Release changed from v3.10 to v3.x

@wixbot
Copy link
Author

wixbot commented Sep 15, 2015

Originally changed by rseanhall
AssignedTo set to shall

@wixbot
Copy link
Author

wixbot commented Sep 15, 2015

The config file must be EmbeddedUI.config, not CustomAction.config.

Originally posted by rseanhall
AssignedTo changed from shall to
Resolutionset tonotabug
Statuschanged fromOpentoResolved

@wixbot
Copy link
Author

wixbot commented Sep 16, 2015

Great. Thank you. The change to the EmbeddedUI.config helps.

It is highly unexpected/unusual that the command line interface expects the argument (which is a file path) with the 'hard codded' file name. But it wouldn't be a huge problem if some sort of error/warning is produced by MakeSfxCA.exe.

Interestingly enough it does the validation and reports the problem if the specified assembly contains both EmbeddedUI and CA implementations. It would be only logical if the same validation routine reports that the specified config file will has unexpected name be ignored. Or better yet if it returns the error.

Is it possible that you can consider extending the input validation? Please let me know if a new feature request needs to be logged.

Thank you for your help.

Originally posted by taras

@wixbot
Copy link
Author

wixbot commented Sep 21, 2015

Yes, please open a feature request.

@wixbot
Copy link
Author

wixbot commented Sep 21, 2015

Great. Done: http://wixtoolset.org/issues/4900/
Thank you

Originally posted by taras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant