Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeSfxCA.exe should validate specified app.config file. #4900

Open
wixbot opened this issue Sep 21, 2015 · 1 comment
Open

MakeSfxCA.exe should validate specified app.config file. #4900

wixbot opened this issue Sep 21, 2015 · 1 comment
Milestone

Comments

@wixbot
Copy link

wixbot commented Sep 21, 2015

This request is triggered by this issue #4891 report: http://wixtoolset.org/issues/4891/

Currently MakeSfxCA silently ignores the specified config file if its naming doesn't follow expected name convention.

Thus it would be beneficial if the existing "EmbeddedUI/CA same assembly collision" validation can also validate (and handle) the assembly config file. The possible handling approaches are:

  • Output the the warning and complete the packaging
  • Output the the error and fail the packaging
  • Create temporary properly named copy of the config file and complete the packaging

Thank you

Originally opened by taras

@wixbot
Copy link
Author

wixbot commented Sep 22, 2015

Release set to v4.x

@wixbot wixbot added this to the v4.x milestone Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant